Add filter_enabled and filter_condition properties #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yob
reviewed
Jun 18, 2021
There was a problem hiding this comment.
Thanks @gu-kevin.
I've tested this manually and confirmed it sets and updates the filter_condition on a pipeline.
The acceptance spec is currently failing. I think you might need to do something like this to the test file:
diff --git a/buildkite/resource_pipeline_test.go b/buildkite/resource_pipeline_test.go
index c2f10a6..c5717e2 100644
--- a/buildkite/resource_pipeline_test.go
+++ b/buildkite/resource_pipeline_test.go
@@ -69,7 +69,7 @@ func TestAccPipeline_add_remove_complex(t *testing.T) {
resource.TestCheckResourceAttr("buildkite_pipeline.foobar", "provider_settings.0.build_tags", "true"),
resource.TestCheckResourceAttr("buildkite_pipeline.foobar", "provider_settings.0.cancel_deleted_branch_builds", "true"),
resource.TestCheckResourceAttr("buildkite_pipeline.foobar", "provider_settings.0.filter_enabled", "true"),
- resource.TestCheckResourceAttr("buildkite_pipeline.foobar", "provider_settings.0.filter_condition", "features/*"),
+ resource.TestCheckResourceAttr("buildkite_pipeline.foobar", "provider_settings.0.filter_condition", "build.pull_request.id == 123"),
resource.TestCheckResourceAttr("buildkite_pipeline.foobar", "provider_settings.0.prefix_pull_request_fork_branch_names", "true"),
resource.TestCheckResourceAttr("buildkite_pipeline.foobar", "provider_settings.0.publish_blocked_as_pending", "true"),
resource.TestCheckResourceAttr("buildkite_pipeline.foobar", "provider_settings.0.publish_commit_status", "true"),
@@ -330,6 +330,8 @@ func testAccPipelineConfigComplex(name string, steps string) string {
build_pull_requests = false
build_tags = true
cancel_deleted_branch_builds = true
+ filter_enabled = true
+ filter_condition = "build.pull_request.id == 123"
prefix_pull_request_fork_branch_names = true
publish_blocked_as_pending = true
publish_commit_status = trueIt'd also be great if the new properties were added to docs/resources/pipeline.md
|
@yob thanks, why did the checks pass on Buildkite? |
yob
approved these changes
Jun 19, 2021
|
Thanks!
By default we don't run the full acceptance test suite on third party pull requests. Mainly because those tests use real credentials to test against a test organization on our live API, so the credentials could be used to make our lives difficult. |
yob
added a commit
that referenced
this pull request
Jun 19, 2021
Support for these was added in PR #157, and full docs are available at https://buildkite.com/docs/pipelines/conditionals#conditionals-in-pipelines
|
Thanks again for this contribution - we've just released v0.5.0 which includes this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#149
Add the filter_enabled and filter_condition properties to pipeline module.
https://buildkite.com/docs/apis/rest-api/pipelines#provider-settings-properties